Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Add flag to disable plan validation #130

Merged
merged 1 commit into from
May 6, 2024
Merged

[CLI] Add flag to disable plan validation #130

merged 1 commit into from
May 6, 2024

Conversation

bplunkett-stripe
Copy link
Collaborator

Description

Optionally disable plan validation for CLI

Motivation

#129

Testing

Just showing the flag is parsed correctly:

 go run ./cmd/pg-schema-diff plan  --dsn "host=localhost database=postgres" --schema-dir ~/stripe/temp/examplesql  --disable-plan-validation --disable-plan-validation

################################ Generated plan ################################
01. CREATE SCHEMA "some_new_schema";
        -- Statement Timeout: 3s

@bplunkett-stripe bplunkett-stripe merged commit 6319a93 into main May 6, 2024
6 checks passed
@bplunkett-stripe bplunkett-stripe deleted the bplunkett/disable-plan-validation-flag branch May 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandrew-stripe dandrew-stripe dandrew-stripe approved these changes

@alexaub-stripe alexaub-stripe Awaiting requested review from alexaub-stripe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bplunkett-stripe @dandrew-stripe